From: Matt Joiner <anacrolix@gmail.com>
Date: Thu, 17 Sep 2015 02:39:51 +0000 (+1000)
Subject: Reduce noise about zero port peers
X-Git-Tag: v1.0.0~1044
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=0113776f1d78ebe3c1a65218932479623fb71ec1;p=btrtrc.git

Reduce noise about zero port peers
---

diff --git a/TODO b/TODO
index e5516862..e512fed6 100644
--- a/TODO
+++ b/TODO
@@ -9,3 +9,4 @@
  * data/blob: Deleting incomplete data triggers io.ErrUnexpectedEOF that isn't recovered from.
  * UL/DL rate-limiting.
  * Handle Torrent being dropped before GotInfo.
+ * Punish sources of bad peers? Some trackers, PEX, and DHT give port 0s, which seems lousy. The spec suggests maybe to not worry about it, but some sources are very persistent.
diff --git a/client.go b/client.go
index 7cb58efe..3e1b7148 100644
--- a/client.go
+++ b/client.go
@@ -1657,10 +1657,6 @@ func (me *Client) connectionLoop(t *torrent, c *connection) error {
 					me.mu.Lock()
 					me.addPeers(t, func() (ret []Peer) {
 						for i, cp := range pexMsg.Added {
-							if cp.Port == 0 {
-								log.Printf("peer gave zero port peer over PEX\n\t%s", c)
-								continue
-							}
 							p := Peer{
 								IP:     make([]byte, 4),
 								Port:   int(cp.Port),
@@ -1846,7 +1842,7 @@ func (me *Client) addPeers(t *torrent, peers []Peer) {
 			continue
 		}
 		if p.Port == 0 {
-			log.Printf("got bad peer: %v", p)
+			// The spec says to scrub these yourselves. Fine.
 			continue
 		}
 		t.addPeer(p)