From: Eric Wong <e@80x24.org>
Date: Sat, 27 Apr 2019 21:46:54 +0000 (+0000)
Subject: extmsg: escape ampersands in @EXT_URL array
X-Git-Tag: v1.2.0~305
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=0cd78b139de44c9018d623d2004d65184fff3275;p=public-inbox.git

extmsg: escape ampersands in @EXT_URL array

We already escape the user-provided Message-IDs (so there's no
security problem AFAIK), but the URL templates which exist in
our source code were not escaped properly.

This quiets down tidy(1).
---

diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
index 14d49cc5..d07d5a79 100644
--- a/lib/PublicInbox/ExtMsg.pm
+++ b/lib/PublicInbox/ExtMsg.pm
@@ -8,13 +8,13 @@
 package PublicInbox::ExtMsg;
 use strict;
 use warnings;
-use PublicInbox::Hval;
+use PublicInbox::Hval qw/ascii_html/;
 use PublicInbox::MID qw/mid2path/;
 use PublicInbox::WwwStream;
 our $MIN_PARTIAL_LEN = 16;
 
 # TODO: user-configurable
-our @EXT_URL = (
+our @EXT_URL = map { ascii_html($_) } (
 	# leading "//" denotes protocol-relative (http:// or https://)
 	'//marc.info/?i=%s',
 	'//www.mail-archive.com/search?l=mid&q=%s',