From: Eric Wong <e@yhbt.net>
Date: Wed, 29 Apr 2020 10:43:34 +0000 (+0000)
Subject: mid: capitalize "ID" in "Message-ID"
X-Git-Tag: v1.5.0~32
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=129c630a7ec3e100bba272631c3880b9beac9cef;p=public-inbox.git

mid: capitalize "ID" in "Message-ID"

Prefer the "ID" capitalization since it seems to to be the
preferred capitalization in RFC 5322.

In theory, this allows the interpreter to deduplicate the string
internally (I haven't checked if it does).

Unfortunately, there's too many instances of "Message-Id" in the
tests to be worth changing at this point.
---

diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 95d654f6..de8ff55f 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -354,7 +354,7 @@ sub v1_mid0 ($) {
 	my $hdr = $mime->header_obj;
 	my $mids = mids($hdr);
 
-	if (!scalar(@$mids)) { # spam often has no Message-Id
+	if (!scalar(@$mids)) { # spam often has no Message-ID
 		my $mid0 = digest2mid(content_digest($mime), $hdr);
 		append_mid($hdr, $mid0);
 		return $mid0;
diff --git a/lib/PublicInbox/MID.pm b/lib/PublicInbox/MID.pm
index dddde092..685306db 100644
--- a/lib/PublicInbox/MID.pm
+++ b/lib/PublicInbox/MID.pm
@@ -72,7 +72,7 @@ sub extract_mids {
 
 sub mids ($) {
 	my ($hdr) = @_;
-	my @mids = $hdr->header_raw('Message-Id');
+	my @mids = $hdr->header_raw('Message-ID');
 	uniq_mids(extract_mids(@mids));
 }
 
@@ -81,7 +81,7 @@ sub mids ($) {
 # import and index without relying on HTTP endpoints
 sub mids_for_index ($) {
 	my ($hdr) = @_;
-	my @mids = $hdr->header_raw('Message-Id');
+	my @mids = $hdr->header_raw('Message-ID');
 	my @alts = $hdr->header_raw('X-Alt-Message-ID');
 	uniq_mids(extract_mids(@mids, @alts));
 }