From: Eric Wong <e@80x24.org>
Date: Tue, 17 Sep 2019 08:31:22 +0000 (+0000)
Subject: http: drop unused `$env' variable after delete
X-Git-Tag: v1.2.0~86
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=1b5b98eb0fb8f9470a94696dc7240bc9adbf402c;p=public-inbox.git

http: drop unused `$env' variable after delete

And explain why we need to do that delete in a comment.
---

diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index b43ef870..cd95f4ab 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -255,7 +255,7 @@ sub next_request ($) {
 sub response_done_cb ($$) {
 	my ($self, $alive) = @_;
 	sub {
-		my $env = delete $self->{env};
+		delete $self->{env}; # we're no longer busy
 		$self->write(\"0\r\n\r\n") if $alive == 2;
 		$self->write($alive ? \&next_request : \&close);
 	}