From: Eric Wong <e@80x24.org>
Date: Fri, 31 May 2019 16:46:04 +0000 (+0000)
Subject: viewdiff: avoid repeat variable expansion
X-Git-Tag: v1.2.0~208
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=209e8ae75919762654e2ffc30aa2d7e86ec535f0;p=public-inbox.git

viewdiff: avoid repeat variable expansion

This is worth a 1-2% speedup in t/perf-msgview.t rendering 2620
messages currently in https://public-inbox.org/meta/
---

diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm
index 6b8d9437..411ed2bb 100644
--- a/lib/PublicInbox/ViewDiff.pm
+++ b/lib/PublicInbox/ViewDiff.pm
@@ -159,7 +159,7 @@ sub flush_diff ($$$) {
 			$state == DSTATE_INIT or
 				to_state($dst, $state, DSTATE_INIT);
 			$$dst .= $s;
-		} elsif ($s =~ m!^diff --git ($PATH_A) ($PATH_B)$!) {
+		} elsif ($s =~ m!^diff --git ($PATH_A) ($PATH_B)$!o) {
 			my ($pa, $pb) = ($1, $2);
 			if ($state != DSTATE_HEAD) {
 				to_state($dst, $state, DSTATE_HEAD);
@@ -194,8 +194,8 @@ sub flush_diff ($$$) {
 			$$dst .= '</span>';
 			$state = DSTATE_CTX;
 			$$dst .= to_html($linkify, $s);
-		} elsif ($s =~ m!^--- (?:$PATH_A)! ||
-		         $s =~ m!^\+{3} (?:$PATH_B)!)  {
+		} elsif ($s =~ m!^--- (?:$PATH_A)!o ||
+		         $s =~ m!^\+{3} (?:$PATH_B)!o)  {
 			# color only (no oid link) if missing dctx->{oid_*}
 			$state <= DSTATE_STAT and
 				to_state($dst, $state, DSTATE_HEAD);