From: Eric Wong <e@80x24.org>
Date: Sun, 30 Aug 2015 01:51:22 +0000 (+0000)
Subject: view: remove "threadlink" from thread view
X-Git-Tag: v1.0.0~957
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=2b3233ce3b309279ee3df8b99a471aa2e8c435e3;p=public-inbox.git

view: remove "threadlink" from thread view

We're already inside the thread, and our thread summary inside
/m/$MESSAGE_ID/ is already sufficient got navigate back to the
/t/$MESSAGE_ID/ page.  So I think it's sufficient to keep the
/t/$MESSAGE_ID/ page lighter with fewer links and avoid
introducing strange terminology.

In contrast, "permalink" is relatively well-known and
not an alien term to readers:

	https://en.wikipedia.org/wiki/Permalink
---

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 7cac7851..3ee67902 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -74,13 +74,10 @@ sub index_entry {
 	my $path = $root_anchor ? '../../' : '';
 	my $href = $mid->as_href;
 	my $irt = $header_obj->header('In-Reply-To');
-	my ($anchor_idx, $anchor, $t_anchor);
+	my ($anchor_idx, $anchor);
 	if (defined $irt) {
 		$anchor_idx = anchor_for($irt);
 		$anchor = $seen->{$anchor_idx};
-		$t_anchor = T_ANCHOR;
-	} else {
-		$t_anchor = '';
 	}
 	if ($srch) {
 		$subj = "<a\nhref=\"${path}t/$href/#u\">$subj</a>";
@@ -134,11 +131,6 @@ sub index_entry {
 		$rv .= " <a\nhref=\"$anchor\">parent</a>";
 	}
 
-	if ($srch) {
-		$rv .= " <a\nhref=\"${path}t/$href/$t_anchor\">" .
-		       "threadlink</a>";
-	}
-
 	$fh->write($rv .= '</pre></td></tr></table>');
 }