From: Eric Wong <e@80x24.org>
Date: Mon, 23 Nov 2020 07:05:58 +0000 (+0000)
Subject: miscidx: cleanup git processes after manifest indexing
X-Git-Tag: v1.7.0~1621
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=2c012a3a2f95d9cf268bd92a61a53fc1633ba8f3;p=public-inbox.git

miscidx: cleanup git processes after manifest indexing

We shouldn't leave "cat-file --batch" processes around when
we're done with an epoch or inbox, since there could be
many thousands.
---

diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index 708f8a3e..890ac282 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -311,6 +311,7 @@ sub _sync_inbox ($$$) {
 	}
 	index_todo($self, $sync, $_) for @{delete($sync->{todo}) // []};
 	$self->{midx}->index_ibx($ibx);
+	$ibx->git->cleanup; # done with this inbox, now
 }
 
 sub eidx_sync { # main entry point
diff --git a/lib/PublicInbox/MiscIdx.pm b/lib/PublicInbox/MiscIdx.pm
index 9dcc96b7..acb49ce7 100644
--- a/lib/PublicInbox/MiscIdx.pm
+++ b/lib/PublicInbox/MiscIdx.pm
@@ -107,6 +107,7 @@ EOF
 			if (my $ent = $git->manifest_entry($epoch, $desc)) {
 				$data->{"$pfx$epoch.git"} = $ent;
 			}
+			$git->cleanup; # ->modified starts cat-file --batch
 		}
 	} elsif (my $ent = $ibx->git->manifest_entry) { # v1
 		$data->{"/$ibx->{name}"} = $ent;