From: Eric Wong Date: Sat, 16 Apr 2016 18:46:35 +0000 (+0000) Subject: view: show flat thread view in chronological order X-Git-Tag: v1.0.0~599 X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=2f8d30432668e0cf17fac08637fecf66cf4e07ac;p=public-inbox.git view: show flat thread view in chronological order Allowing readers new to a topic to follow in chronological order probably makes the most sense. Reverse chronological order may reduce scrolling (e.g. log view); but nearly all non-threaded conversation displays seem to be chronological so perhaps there's a good reason for that. --- diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index f07979e9..36df7ead 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -174,10 +174,10 @@ sub thread_html { sub emit_thread_html { my ($res, $ctx, $foot, $srch) = @_; my $mid = $ctx->{mid}; - my $msgs = load_results($srch->get_thread($mid)); + my $flat = $ctx->{flat}; + my $msgs = load_results($srch->get_thread($mid, { asc => $flat })); my $nr = scalar @$msgs; return missing_thread($res, $ctx) if $nr == 0; - my $flat = $ctx->{flat}; my $seen = {}; my $state = { res => $res,