From: Eric Wong <e@80x24.org>
Date: Fri, 24 Sep 2021 10:56:43 +0000 (+0000)
Subject: clone|--mirror: fix and test against pre-manifest WWW
X-Git-Tag: v1.7.0~284
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=3596019278ef489f27e0659c752977f60f847903;hp=3596019278ef489f27e0659c752977f60f847903;p=public-inbox.git

clone|--mirror: fix and test against pre-manifest WWW

There may still be pre-manifest.js.gz versions of PublicInbox::WWW.
running and serving v2 inboxes.

Since $INBOX_URL/manifest.js.gz was not understood, it was
assumed to be a Message-ID and 301-ed to
"$INBOX_URL/manifest.js.gz/" with a trailing slash, so our 404
checks were invalid.  Update our fallbacks to deal with 301
by catching JSON decoding errors to trigger HTML scraping.

For HTML parsing, be sure to not be fooled by potential
user-generated content and only scan the part after the last
<hr>.

We also need to avoid propagating $? from curl unnecessarily
when we can continue safely.

Finally, update v2mirror.t with tests to use PublicInbox::WWW
from our "v1.1.0-pre1" tag to ensure these code paths get tested
---