From: Eric Wong <e@80x24.org>
Date: Sun, 15 Dec 2019 03:37:56 +0000 (+0000)
Subject: searchidx: do not modify read-only $1 via git_unquote
X-Git-Tag: v1.3.0~226
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=3b3b25d8e68b71fac10ff17d28c89198fd76d1fc;p=public-inbox.git

searchidx: do not modify read-only $1 via git_unquote

git_unquote works in-place, and we sometimes see strange
filenames, or badly munged diffs with terminal escape
characters (for colorization) end up in emails.
---

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index f265fa7f..926fac80 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -204,11 +204,13 @@ sub index_diff ($$$) {
 			$in_diff = $self->index_old_diff_fn(\%seen, $fa, $fb,
 							$xnq);
 		} elsif (m!^--- ("?a/.+)!) {
-			my $fn = (split('/', git_unquote($1), 2))[1];
+			my $fn = $1;
+			$fn = (split('/', git_unquote($fn), 2))[1];
 			$seen{$fn}++ or $self->index_diff_inc($fn, 'XDFN', $xnq);
 			$in_diff = 1;
 		} elsif (m!^\+\+\+ ("?b/.+)!)  {
-			my $fn = (split('/', git_unquote($1), 2))[1];
+			my $fn = $1;
+			$fn = (split('/', git_unquote($fn), 2))[1];
 			$seen{$fn}++ or $self->index_diff_inc($fn, 'XDFN', $xnq);
 			$in_diff = 1;
 		} elsif (/^--- (\S+)/) {