From: Eric Wong <e@80x24.org>
Date: Tue, 24 Jan 2023 09:49:37 +0000 (+0000)
Subject: viewvcs: show message for 404||500 errors
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=4c371ef706ba5d5d0487ff8a9e4b75d168a6e267;p=public-inbox.git

viewvcs: show message for 404||500 errors

Since the debug log isn't present from the /$REPO/ URLs,
the lack of debug log makes 404s look confusing.
---

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 0dfe6081..99f5e24f 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -497,8 +497,9 @@ sub show_tag ($$) {
 sub solve_result {
 	my ($res, $ctx) = @_;
 	my $hints = delete $ctx->{hints};
-	$res or return html_page($ctx, 404, dbg_log($ctx));
-	ref($res) eq 'ARRAY' or return html_page($ctx, 500, dbg_log($ctx));
+	$res or return html_page($ctx, 404, 'Not found', dbg_log($ctx));
+	ref($res) eq 'ARRAY' or
+		return html_page($ctx, 500, 'Internal error', dbg_log($ctx));
 
 	my ($git, $oid, $type, $size, $di) = @$res;
 	return show_commit($ctx, $res) if $type eq 'commit';