From: Eric Wong <e@yhbt.net>
Date: Sat, 15 Feb 2020 09:46:38 +0000 (+0000)
Subject: view: escape Subject HTML directly
X-Git-Tag: v1.4.0~113
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=4c4de0022f40e09c4db7665cc573a3cb94f753a3;p=public-inbox.git

view: escape Subject HTML directly

No need to use the over-engineered Hval OO API when the subject
is already normalized and there's no trailing spaces because of
normalization.
---

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 033a0c14..d4bfa62d 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -1090,7 +1090,7 @@ sub dump_topics {
 		my $mid = delete $seen->{$top_subj};
 		my $href = mid_escape($mid);
 		my $prev_subj = [ split(/ /, $top_subj) ];
-		$top_subj = PublicInbox::Hval->new($top_subj)->as_html;
+		$top_subj = ascii_html($top_subj);
 		$ds = fmt_ts($ds);
 
 		# $n isn't the total number of posts on the topic,