From: Matt Joiner <anacrolix@gmail.com>
Date: Wed, 11 May 2022 04:14:25 +0000 (+1000)
Subject: Use intermediate t in Peer.getDesiredRequestState
X-Git-Tag: v1.43.0~5
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=4eb6a49f27cefcb8ce07822af9ae4348ce42c6a7;p=btrtrc.git

Use intermediate t in Peer.getDesiredRequestState
---

diff --git a/requesting.go b/requesting.go
index ece5dc39..3c204b84 100644
--- a/requesting.go
+++ b/requesting.go
@@ -184,22 +184,23 @@ type desiredRequestState struct {
 }
 
 func (p *Peer) getDesiredRequestState() (desired desiredRequestState) {
-	if !p.t.haveInfo() {
+	t := p.t
+	if !t.haveInfo() {
 		return
 	}
-	if p.t.closed.IsSet() {
+	if t.closed.IsSet() {
 		return
 	}
-	input := p.t.getRequestStrategyInput()
+	input := t.getRequestStrategyInput()
 	requestHeap := desiredPeerRequests{
 		peer:        p,
 		pieceStates: make(map[pieceIndex]request_strategy.PieceRequestOrderState),
 	}
 	request_strategy.GetRequestablePieces(
 		input,
-		p.t.getPieceRequestOrder(),
+		t.getPieceRequestOrder(),
 		func(ih InfoHash, pieceIndex int, pieceExtra request_strategy.PieceRequestOrderState) {
-			if ih != p.t.infoHash {
+			if ih != t.infoHash {
 				return
 			}
 			if !p.peerHasPiece(pieceIndex) {
@@ -231,7 +232,7 @@ func (p *Peer) getDesiredRequestState() (desired desiredRequestState) {
 			})
 		},
 	)
-	p.t.assertPendingRequests()
+	t.assertPendingRequests()
 	desired.Requests = requestHeap
 	return
 }