From: Eric Wong <e@80x24.org>
Date: Fri, 24 May 2019 01:12:08 +0000 (+0000)
Subject: search: don't log all warnings on retry_reopen
X-Git-Tag: v1.2.0~234
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=5b05a7c7a65a25b938ebf2fdbce0d4b4fadfbd3c;hp=666f1b8f5c7c76333df4e1296c1668abf04f210f;p=public-inbox.git

search: don't log all warnings on retry_reopen

Some users (or bots :P) can trigger horrible queries which
the caller can choose to either log or ignore.  This prevents
horrible queries from ExtMsg from logging confusing "ref: "
messages when $@ is not a Perl reference.
---

diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index d861cf47..c054a874 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -228,7 +228,9 @@ sub retry_reopen {
 			warn "reopen try #$i on $@\n";
 			reopen($self);
 		} else {
-			warn "ref: ", ref($@), "\n";
+			# let caller decide how to spew, because ExtMsg queries
+			# get wonky and trigger:
+			# "something terrible happened at .../Xapian/Enquire.pm"
 			die;
 		}
 	}