From: Matt Joiner <anacrolix@gmail.com>
Date: Thu, 21 Mar 2024 21:15:37 +0000 (+1100)
Subject: Document use of the ExtensionBitV2Upgrade reserved bit
X-Git-Tag: v1.56.0~38
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=5ddf3003bbdb72eded04bf7d4d623ffab4d6bb37;p=btrtrc.git

Document use of the ExtensionBitV2Upgrade reserved bit
---

diff --git a/peer_protocol/handshake.go b/peer_protocol/handshake.go
index bce28340..a6512c79 100644
--- a/peer_protocol/handshake.go
+++ b/peer_protocol/handshake.go
@@ -22,7 +22,7 @@ const (
 	ExtensionBitFast = 2 // http://www.bittorrent.org/beps/bep_0006.html
 	// A peer connection initiator can set this when sending a v1 infohash during handshake if they
 	// allow the receiving end to upgrade to v2 by responding with the corresponding v2 infohash.
-	// BEP 52, and BEP 4
+	// BEP 52, and BEP 4. TODO: Set by default and then clear it when it's not appropriate to send.
 	ExtensionBitV2Upgrade                    = 4
 	ExtensionBitAzureusExtensionNegotiation1 = 16
 	ExtensionBitAzureusExtensionNegotiation2 = 17