From: Eric Wong <e@yhbt.net>
Date: Sat, 27 Jun 2020 10:03:49 +0000 (+0000)
Subject: watch: imap: be quiet about disconnecting on quit
X-Git-Tag: v1.6.0~328
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=5f03b6c95af21dc2d499618ba03d63c44f70828c;p=public-inbox.git

watch: imap: be quiet about disconnecting on quit

If ->idle_done was handled successfully, we can just
let normal ->DESTROY disconnect and avoid ugly backtraces
when a user hits Ctrl-C to take down the process group.
---

diff --git a/lib/PublicInbox/WatchMaildir.pm b/lib/PublicInbox/WatchMaildir.pm
index 05aa6594..e4106490 100644
--- a/lib/PublicInbox/WatchMaildir.pm
+++ b/lib/PublicInbox/WatchMaildir.pm
@@ -208,9 +208,11 @@ sub quit {
 	}
 	if (my $idle_mic = $self->{idle_mic}) {
 		eval { $idle_mic->done };
-		warn "IDLE DONE error: $@\n" if $@;
-		eval { $idle_mic->disconnect };
-		warn "IDLE LOGOUT error: $@\n" if $@;
+		if ($@) {
+			warn "IDLE DONE error: $@\n";
+			eval { $idle_mic->disconnect };
+			warn "IDLE LOGOUT error: $@\n" if $@;
+		}
 	}
 }