From: shane.xb.qian <shane.qian@foxmail.com>
Date: Thu, 13 Apr 2023 17:19:13 +0000 (+0800)
Subject: none: rephrase the word and var and default value of additionalTextEdits
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=64f9aa736605e3647beb11f80057063600d17b76;p=vim-lsp.git

none: rephrase the word and var and default value of additionalTextEdits

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
---

diff --git a/autoload/lsp/completion.vim b/autoload/lsp/completion.vim
index 7702e6d..25039f2 100644
--- a/autoload/lsp/completion.vim
+++ b/autoload/lsp/completion.vim
@@ -517,7 +517,7 @@ def LspCompleteDone()
   var completionData: any = v:completed_item->get('user_data', '')
   if completionData->type() != v:t_dict
       || !completionData->has_key('additionalTextEdits')
-      || opt.lspOptions.noAdditionalTextEdits
+      || !opt.lspOptions.completionTextEdit
     return
   endif
 
diff --git a/autoload/lsp/options.vim b/autoload/lsp/options.vim
index b769063..3a6e753 100644
--- a/autoload/lsp/options.vim
+++ b/autoload/lsp/options.vim
@@ -33,9 +33,10 @@ export var lspOptions: dict<any> = {
   ignoreMissingServer: false,
   # Focus on the location list window after LspShowReferences
   keepFocusInReferences: false,
-  # If not apply LSP server-initiated actions after completion
-  # specially if some others plugins had registered to do that
-  noAdditionalTextEdits: false,
+  # If true, apply the LSP server supplied text edits after a completion.
+  # If a snippet plugin is going to apply the text edits, then set this to
+  # false to avoid applying the text edits twice.
+  completionTextEdit: true,
   # instead of the signature
   noDiagHoverOnLine: true,
   # Suppress adding a new line on completion selection with <CR>
diff --git a/doc/lsp.txt b/doc/lsp.txt
index 43478e0..84dcfb8 100644
--- a/doc/lsp.txt
+++ b/doc/lsp.txt
@@ -395,10 +395,11 @@ keepFocusInReferences	|Boolean| option.  Focus on the location list window
 			after LspShowReferences.
 			By default this is set to false.
 						*lsp-opt-noAdditionalTextEdits*
-noAdditionalTextEdits	|Boolean| option.  If not apply LSP server-initiated
-			actions after completion, specially if some others
-			plugins had registered to do that.
-			By default this is set to false.
+completionTextEdit	|Boolean| option.  If true, apply the LSP server
+			supplied text edits after a completion.  If a snippet
+			plugin is going to apply the text edits, then set
+			this to false to avoid applying the text edits twice.
+			By default this is set to true.
 						*lsp-opt-noDiagHoverOnLine*
 noDiagHoverOnLine	|Boolean| option.  Suppress diagnostic hover from
 			appearing when the mouse is over the line instead of