From: Eric Wong <e@80x24.org>
Date: Thu, 4 Aug 2022 08:16:58 +0000 (+0000)
Subject: over: get_xref3: modify rows in-place
X-Git-Tag: v1.9.0~52
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=674b0268c057d852342347264b374ef0cd130e51;p=public-inbox.git

over: get_xref3: modify rows in-place

There's no need to create two intermediate arrays when we can
modify the existing arrayref.
---

diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index 786f9d92..d6409b2a 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -273,13 +273,13 @@ SELECT ibx_id,xnum,oidbin FROM xref3 WHERE docid = ? ORDER BY ibx_id,xnum ASC
 	my $eidx_key_sth = $dbh->prepare_cached(<<'', undef, 1);
 SELECT eidx_key FROM inboxes WHERE ibx_id = ?
 
-	[ map {
-		my $r = $_;
+	for my $r (@$rows) {
 		$eidx_key_sth->execute($r->[0]);
 		my $eidx_key = $eidx_key_sth->fetchrow_array;
 		$eidx_key //= "missing://ibx_id=$r->[0]";
-		"$eidx_key:$r->[1]:".unpack('H*', $r->[2]);
-	} @$rows ];
+		$r = "$eidx_key:$r->[1]:".unpack('H*', $r->[2]);
+	}
+	$rows;
 }
 
 sub next_by_mid {