From: Eric Wong Date: Mon, 10 Oct 2022 21:34:20 +0000 (+0000) Subject: viewvcs: avoid one ascii_html call X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=695aa875bb5ee37c03a4e0ff4ef7d0ec7802a933;p=public-inbox.git viewvcs: avoid one ascii_html call We can reuse its result for the button text. --- diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index 72b79ab7..86bae7d6 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -247,9 +247,14 @@ EOM my $rows = ($q =~ tr/\n/\n/) + 1; $q = ascii_html($q); my $ibx_url = ibx_url_for($ctx); - my $alt = $ibx_url ? ' '.ascii_html($ibx_url) : ''; - $ibx_url = ascii_html($ibx_url) if defined $ibx_url; - $ibx_url //= $upfx; + my $alt; + if (defined $ibx_url) { + $ibx_url = ascii_html($ibx_url); + $alt = ' '.$ibx_url; + } else { + $ibx_url = $upfx; + $alt = ''; + } print $zfh <