From: Eric Wong <e@80x24.org>
Date: Sat, 10 Sep 2022 08:17:14 +0000 (+0000)
Subject: view: html_footer: avoid escaping " in a few places
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=7909a26697d91a74a3b4df638b2a658432f1b799;p=public-inbox.git

view: html_footer: avoid escaping " in a few places

qq() is a nice alternative to "" when there's embedded "
characters in HTML entities.
---

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 40b4bf36..2f99179e 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -819,23 +819,23 @@ EOF
 
 		if (my $n = $ctx->{next_msg}) {
 			$n = mid_href($n);
-			$next = "<a\nhref=\"$upfx$n/\"\nrel=next>next</a>";
+			$next = qq(<a\nhref="$upfx$n/"\nrel=next>next</a>);
 		}
 		my $par = $ctx->{parent_msg};
 		my $u = $par ? $upfx.mid_href($par).'/' : undef;
 		if (my $p = $ctx->{prev_msg}) {
 			$prev = mid_href($p);
 			if ($p && $par && $p eq $par) {
-				$prev = "<a\nhref=\"$upfx$prev/\"\n" .
+				$prev = qq(<a\nhref="$upfx$prev/"\n) .
 					'rel=prev>prev parent</a>';
 				$parent = '';
 			} else {
-				$prev = "<a\nhref=\"$upfx$prev/\"\n" .
+				$prev = qq(<a\nhref="$upfx$prev/"\n) .
 					'rel=prev>prev</a>';
-				$parent = " <a\nhref=\"$u\">parent</a>" if $u;
+				$parent = qq( <a\nhref="$u">parent</a>) if $u;
 			}
 		} elsif ($u) { # unlikely
-			$parent = " <a\nhref=\"$u\"\nrel=prev>parent</a>";
+			$parent = qq( <a\nhref="$u"\nrel=prev>parent</a>);
 		}
 		$foot .= "$next $prev$parent ";
 	} else { # unindexed inboxes w/o over