From: Eric Wong <e@80x24.org>
Date: Wed, 6 Apr 2016 08:23:15 +0000 (+0000)
Subject: view: account for threads lacking a common parent
X-Git-Tag: v1.0.0~618
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=7fe73c43efaa408d4dc8a5d8b9988feef7ff9f19;p=public-inbox.git

view: account for threads lacking a common parent

In the per-message view, we still need to account for threads
lacking a common parent.  This can happen when threads are
broken by some broken clients or if somebody sends the same
message twice to the same inbox with a different Message-ID.
---

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index c25c5d57..070240ec 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -819,13 +819,18 @@ sub inline_dump {
 		my $mid = mid_clean($hdr->header_raw('Message-ID'));
 		_inline_header($dst, $state, $upfx, $hdr, $level);
 	} else {
-		my $dot = $level == 0 ? '' : '` ';
-		my $pfx = '      [not found] ' .  indent_for($level) . $dot;
-		$$dst .= $pfx;
-		my $mid = PublicInbox::Hval->new_msgid($node->messageid);
-		my $href = $mid->as_href;
-		my $html = $mid->as_html;
-		$$dst .= qq{&lt;<a\nhref="$upfx../$href/">$html</a>&gt;\n};
+		my $mid = $node->messageid;
+		if ($mid eq 'subject dummy') {
+			$$dst .= "\t[no common parent]\n";
+		} else {
+			$$dst .= '      [not found] ';
+			my $dot = $level == 0 ? '' : '` ';
+			$$dst .= indent_for($level) . $dot;
+			$mid = PublicInbox::Hval->new_msgid($mid);
+			my $href = "$upfx../" . $mid->as_href . '/';
+			my $html = $mid->as_html;
+			$$dst .= qq{&lt;<a\nhref="$href">$html</a>&gt;\n};
+		}
 	}
 	inline_dump($dst, $state, $upfx, $node->child, $level+1);
 	inline_dump($dst, $state, $upfx, $node->next, $level);