From: Eric Wong <e@80x24.org>
Date: Wed, 23 Dec 2020 08:38:50 +0000 (+0000)
Subject: config: _fill: inbox name extraction optimization
X-Git-Tag: v1.7.0~1507
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=83a03a80c7392148fa65143f60fb16d15cf19006;p=public-inbox.git

config: _fill: inbox name extraction optimization

Using substr() instead of a string copy + s// substitution here
reduces ->fill_all from 4.00s to 3.88s with 50K inboxes on my
workstation.
---

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index 577337dc..cd8957a1 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -424,9 +424,7 @@ EOF
 		}
 	}
 
-	my $name = $pfx;
-	$name =~ s/\Apublicinbox\.//;
-
+	my $name = substr($pfx, length('publicinbox.'));
 	if (!valid_inbox_name($name)) {
 		warn "invalid inbox name: '$name'\n";
 		return;