From: Eric Wong <e@80x24.org>
Date: Mon, 16 Dec 2019 08:07:34 +0000 (+0000)
Subject: t/edit.t: drop redundant "delete local $ENV{...}"
X-Git-Tag: v1.3.0~219
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=8d801146e36c42175a709bfdc90137fddc5c0862;p=public-inbox.git

t/edit.t: drop redundant "delete local $ENV{...}"

"delete local" is only in Perl v5.11.0, and we only depend on
Perl v5.10.1.  We already localize and delete it as two separate
statements immediately above.

I wish this was hidden behind a "use feature" flag like other
new-fangled things :<.  Oh well, I think the oldest Perl actually
in use for this project is 5.16 (CentOS 7.x).
---

diff --git a/t/edit.t b/t/edit.t
index 02df6cda..122aa19f 100644
--- a/t/edit.t
+++ b/t/edit.t
@@ -129,7 +129,6 @@ $t = 'mailEditor set in config'; {
 	is($rc, 0, 'set publicinbox.mailEditor');
 	local $ENV{MAIL_EDITOR};
 	delete $ENV{MAIL_EDITOR};
-	delete local $ENV{MAIL_EDITOR};
 	local $ENV{GIT_EDITOR} = 'echo should not run';
 	$cmd = [ '-edit', "-m$mid", $inboxdir ];
 	ok(run_script($cmd, undef, $opt), "$t edited message");