From: Eric Wong <e@80x24.org>
Date: Tue, 31 Dec 2019 10:30:11 +0000 (+0000)
Subject: githttpbackend: remove ancient compatibility check
X-Git-Tag: v1.3.0~173
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=8de49b2d3097e294650b1ee1554f45c6d2d29d67;p=public-inbox.git

githttpbackend: remove ancient compatibility check

The ref() call could be hitting memory leaks on Perl 5.16.x.

It's been 3 years (2016-12-25) since 292ca34140489da2
("githttpbackend: simplify compatibility code") back when
this project was barely known and probably nobody used
examples/public-inbox.psgi...
---

diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 8dd27a75..8883ec34 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -47,9 +47,6 @@ sub r ($;$) {
 sub serve {
 	my ($env, $git, $path) = @_;
 
-	# XXX compatibility... ugh, can we stop supporting this?
-	$git = PublicInbox::Git->new($git) unless ref($git);
-
 	# Documentation/technical/http-protocol.txt in git.git
 	# requires one and exactly one query parameter:
 	if ($env->{QUERY_STRING} =~ /\Aservice=git-[A-Za-z0-9_]+-pack\z/ ||