From: Eric Wong <e@80x24.org>
Date: Sun, 17 Oct 2021 09:52:49 +0000 (-1100)
Subject: extindex: guard against false mismatch unrefs
X-Git-Tag: v1.7.0~113
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=9406144c54215626e79ee65fc3c89ff350506317;p=public-inbox.git

extindex: guard against false mismatch unrefs

I'm not sure if this is a bug or not (or it could be
an old bug in the v2 indexing code).
---

diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index daff656d..cb5256a2 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -921,6 +921,16 @@ ibx_id = ? AND xnum >= ? AND xnum <= ?
 			my ($xnum, $hex) = unpack('JH*', $k);
 			my $bin = pack('H*', $hex);
 			my $exp = $mismatch{$xnum};
+			if (defined $exp) {
+				my $smsg = $ibx->over->get_art($xnum) // next;
+				# $xnum may be expired by another process
+				if ($smsg->{blob} eq $hex) {
+					warn <<"";
+BUG: (non-fatal) $ekey #$xnum $smsg->{blob} still matches (old exp: $exp)
+
+					next;
+				} # else: continue to unref
+			}
 			my $m = defined($exp) ? "mismatch (!= $exp)" : 'stale';
 			warn("# $xnum:$hex (#@$docids): $m\n");
 			for my $i (@$docids) {