From: Eric Wong <e@80x24.org> Date: Sat, 22 Aug 2020 00:41:25 +0000 (+0000) Subject: searchview: fix mbox.gz downloads for lynx users X-Git-Tag: v1.6.0~110 X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=99404a3bc0ab01b4f10ea698d88642b2ebc932e1;p=public-inbox.git searchview: fix mbox.gz downloads for lynx users Unlike w3m and links, the lynx browser seems to require a `name' attribute for `<input type=submit>' elements. Maybe some other browsers do, too. The `name' attribute for submit elements doesn't seem to cause any harm for w3m or links, users, either; despite not (AFAIK) being part of historical or current HTML specs. --- diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm index aa8fa037..75e2d39d 100644 --- a/lib/PublicInbox/SearchView.pm +++ b/lib/PublicInbox/SearchView.pm @@ -185,9 +185,11 @@ sub search_nav_top { $rv .= qq{<a\nhref="?$s">summary</a>|<b>nested</b>}; } my $A = $q->qs_html(x => 'A', r => undef); - $rv .= qq{|<a\nhref="?$A">Atom feed</a>]}; - $rv .= qq{\n\t\t\t\t\t\tdownload: }; - $rv .= qq{<input\ntype=submit\nvalue="mbox.gz"/></pre></form><pre>}; + $rv .= qq{|<a\nhref="?$A">Atom feed</a>]} . + qq{\n\t\t\t\t\t\tdownload: } . + # lynx seems to require a name=, here, so just use 'z' + qq{<input\ntype=submit\nname=z\nvalue="mbox.gz"/>} . + q{</pre></form><pre>}; } sub search_nav_bot {