From: Eric Wong <e@yhbt.net>
Date: Sat, 9 May 2020 08:27:38 +0000 (+0000)
Subject: emlcontentfoo: quiet warning on missing attributes
X-Git-Tag: v1.5.0~5
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=a0b53e7c83c2773ba80fdd188ad5537a0408f997;p=public-inbox.git

emlcontentfoo: quiet warning on missing attributes

This bug was also present in Email::MIME::ContentType:
commit ae081fb576d8507efca4928116ad81efa756c723 (refs/pull/pull/9/head)
in https://github.com/rjbs/Email-MIME-ContentType.git

Our fix is shorter, but dependent on 5.10+ as our codebase
relies on Perl 5.10 features, anyways.
---

diff --git a/lib/PublicInbox/EmlContentFoo.pm b/lib/PublicInbox/EmlContentFoo.pm
index 7472f8d2..e6005d29 100644
--- a/lib/PublicInbox/EmlContentFoo.pm
+++ b/lib/PublicInbox/EmlContentFoo.pm
@@ -190,7 +190,7 @@ sub _process_rfc2231 {
 	foreach (keys %{$attribs}) {
 		next unless $_ =~ m/^(.*)\*$/;
 		my $key = $1;
-		next unless $attribs->{$_} =~ m/^$re_exvalue$/;
+		next unless ($attribs->{$_} // '') =~ m/^$re_exvalue$/;
 		my ($charset, $value) = ($1, $2);
 		$value =~ s/%([0-9A-Fa-f]{2})/pack('C', hex($1))/eg;
 		if (length $charset) {