From: Eric Wong <e@80x24.org>
Date: Sat, 26 Dec 2020 08:12:52 +0000 (+0000)
Subject: inbox: name variable for values loop iterator
X-Git-Tag: v1.7.0~1490
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=b5e960f50289434025f5904c8c1311e4c8a02b82;p=public-inbox.git

inbox: name variable for values loop iterator

->on_inbox_unlock callbacks could clobber $_, and this seems to
fix a problem with -extindex --watch failing to index some
inboxes after SIGHUP reload.
---

diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index ec8469e3..1b9b56ff 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -414,8 +414,8 @@ sub on_unlock {
 	my ($self) = @_;
 	check_inodes($self);
 	my $subs = $self->{unlock_subs} or return;
-	for (values %$subs) {
-		eval { $_->on_inbox_unlock($self) };
+	for my $obj (values %$subs) {
+		eval { $obj->on_inbox_unlock($self) };
 		warn "E: $@ ($self->{inboxdir})\n" if $@;
 	}
 }