From: Eric Wong <e@80x24.org>
Date: Thu, 16 Jun 2016 22:45:24 +0000 (+0000)
Subject: msg_iter: support read-only elements
X-Git-Tag: v1.0.0~435
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=c1de840e23416eea63739b21995b07b2e8a1e9ac;p=public-inbox.git

msg_iter: support read-only elements

Apparently, it's possible to have read-only bodies in
Email::MIME objects.  Haven't gotten a chance to reliably
reproduce it, though...
---

diff --git a/lib/PublicInbox/MsgIter.pm b/lib/PublicInbox/MsgIter.pm
index e0127ab9..ef0d209f 100644
--- a/lib/PublicInbox/MsgIter.pm
+++ b/lib/PublicInbox/MsgIter.pm
@@ -7,6 +7,7 @@ use warnings;
 use base qw(Exporter);
 our @EXPORT = qw(msg_iter);
 use Email::MIME;
+use Scalar::Util qw(readonly);
 
 # Workaround Email::MIME versions without
 # commit dcef9be66c49ae89c7a5027a789bbbac544499ce
@@ -36,7 +37,14 @@ sub msg_iter ($$) {
 				@parts = (@sub, @parts);
 			} else {
 				if ($extra_nl) {
-					${$part->{body}} .= $part->{mycrlf};
+					my $lf = $part->{mycrlf};
+					my $bref = $part->{body};
+					if (readonly($$bref)) {
+						my $s = $$bref . $lf;
+						$part->{body} = \$s;
+					} else {
+						$$bref .= $lf;
+					}
 				}
 				$cb->($p);
 			}