From: Eric Wong Date: Sat, 10 Sep 2022 08:17:12 +0000 (+0000) Subject: view: html_footer: golf out a few lines X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=c28e2f8b175cefeafba7c4e9fbb65e5b6021dded;p=public-inbox.git view: html_footer: golf out a few lines We can build `$u' in one line, and drop an unnecessary empty line to reduce the amount of scrolling required to read this sub. --- diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 52d37a9f..b27523b2 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -811,7 +811,6 @@ ${fallback}other threads:[~$t_fmt UTC|newest] EOF - thread_skel(\$skel, $ctx, $hdr); my ($next, $prev); my $parent = ' '; @@ -821,12 +820,8 @@ EOF $n = mid_href($n); $next = "next"; } - my $u; my $par = $ctx->{parent_msg}; - if ($par) { - $u = mid_href($par); - $u = "$upfx$u/"; - } + my $u = $par ? $upfx.mid_href($par).'/' : undef; if (my $p = $ctx->{prev_msg}) { $prev = mid_href($p); if ($p && $par && $p eq $par) {