From: Matt Joiner <anacrolix@gmail.com>
Date: Thu, 16 Sep 2021 07:08:59 +0000 (+1000)
Subject: request_strategy.Peer.canRequestPiece performance: Reorder conditions
X-Git-Tag: v1.32.0~40
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=dd52a1440f05e3d6513ecaa3affbec730c118f21;p=btrtrc.git

request_strategy.Peer.canRequestPiece performance: Reorder conditions
---

diff --git a/request-strategy/peer.go b/request-strategy/peer.go
index 21ef0d2e..b6222064 100644
--- a/request-strategy/peer.go
+++ b/request-strategy/peer.go
@@ -34,5 +34,5 @@ func (p *Peer) pieceAllowedFastOrDefault(i pieceIndex) bool {
 
 // TODO: This might be used in more places I think.
 func (p *Peer) canRequestPiece(i pieceIndex) bool {
-	return p.HasPiece(i) && (!p.Choking || (p.PieceAllowedFast != nil && p.PieceAllowedFast(i)))
+	return (!p.Choking || p.pieceAllowedFastOrDefault(i)) && p.HasPiece(i)
 }