From: Eric Wong <e@yhbt.net>
Date: Mon, 1 Jun 2020 10:06:55 +0000 (+0000)
Subject: smsg: remove ->bytes and ->lines methods
X-Git-Tag: v1.6.0~471
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=dee9a7231ca1019f56eea3596f0c428769e3eac1;p=public-inbox.git

smsg: remove ->bytes and ->lines methods

They're stored directly in Xapian and SQLite document data.
NNTP accesses those fields directly to avoid method invocation
overhead so there's no reason to waste several kilobytes for
each sub.
---

diff --git a/lib/PublicInbox/Smsg.pm b/lib/PublicInbox/Smsg.pm
index 9e363a11..a7ee2e40 100644
--- a/lib/PublicInbox/Smsg.pm
+++ b/lib/PublicInbox/Smsg.pm
@@ -90,10 +90,6 @@ sub from_mitem {
 	psgi_cull(load_expand($self, $mitem->get_document));
 }
 
-# :bytes and :lines metadata in RFC 3977
-sub bytes ($) { $_[0]->{bytes} }
-sub lines ($) { $_[0]->{lines} }
-
 sub __hdr ($$) {
 	my ($self, $field) = @_;
 	$self->{lc($field)};