From: Eric Wong <e@80x24.org>
Date: Sun, 8 Jan 2023 08:04:12 +0000 (+0000)
Subject: config: do not implicitly set coderepo.*.cgiturl
X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=f0d445048bc5d3de05a963d9a024279a93152c1f;p=public-inbox.git

config: do not implicitly set coderepo.*.cgiturl

It's a needless waste of memory and this change reduces the
WwwCoderepo object size by over 25% with over 1K repos.
Using the following check:

  perl -MDevel::Size=total_size -I lib -MPublicInbox::WwwCoderepo -E \
  'say total_size(PublicInbox::WwwCoderepo->new(PublicInbox::Config->new))'

before: 1612515
 after: 1184385
---

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index 174c75ef..c48ab2bd 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -226,7 +226,6 @@ sub cgit_repo_merge ($$$) {
 			$rel =~ s!/?\.git\z!!;
 	}
 	$self->{"coderepo.$rel.dir"} //= $path;
-	$self->{"coderepo.$rel.cgiturl"} //= _array($rel);
 }
 
 sub is_git_dir ($) {