From: Eric Wong Date: Sat, 7 Jan 2017 01:44:50 +0000 (+0000) Subject: remove incorrect comment about strftime + locales X-Git-Tag: v1.0.0~100 X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=f63ea68e457f9e2618eac1d3d62227d2b605651b;p=public-inbox.git remove incorrect comment about strftime + locales We only need strftime to be locale-independent when generating dates for email and HTTP headers. Purely numeric dates can use strftime for ease-of-readability. --- diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm index 96406c6f..4522eb62 100644 --- a/lib/PublicInbox/SearchMsg.pm +++ b/lib/PublicInbox/SearchMsg.pm @@ -69,7 +69,7 @@ sub subject ($) { __hdr($_[0], 'subject') } sub to ($) { __hdr($_[0], 'to') } sub cc ($) { __hdr($_[0], 'cc') } -# no strftime, that is locale-dependent +# no strftime, that is locale-dependent and not for RFC822 my @DoW = qw(Sun Mon Tue Wed Thu Fri Sat); my @MoY = qw(Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec); diff --git a/lib/PublicInbox/WwwAtomStream.pm b/lib/PublicInbox/WwwAtomStream.pm index a6817b31..5a10034b 100644 --- a/lib/PublicInbox/WwwAtomStream.pm +++ b/lib/PublicInbox/WwwAtomStream.pm @@ -6,7 +6,6 @@ package PublicInbox::WwwAtomStream; use strict; use warnings; -# FIXME: locale-independence: use POSIX qw(strftime); use Date::Parse qw(strptime); use Digest::SHA qw(sha1_hex);