From: Eric Wong Date: Fri, 14 Jun 2019 07:34:07 +0000 (+0000) Subject: v2writable: update comments regarding xcpdb --reshard X-Git-Tag: v1.2.0~165^2~18 X-Git-Url: http://www.git.stargrave.org/?a=commitdiff_plain;h=f7651f3fea8cea0ee1f6567cc53f93a57a652a47;p=public-inbox.git v2writable: update comments regarding xcpdb --reshard Using compact to change shard count was abandoned during the v2 development phase. --- diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index 76e61e86..db905f92 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -58,8 +58,8 @@ sub count_partitions ($) { my $xpfx = $self->{xpfx}; # always load existing partitions in case core count changes: - # Also, partition count may change while -watch is running - # due to -compact + # Also, shard count may change while -watch is running + # due to "xcpdb --reshard" if (-d $xpfx) { foreach my $part (<$xpfx/*>) { -d $part && $part =~ m!/[0-9]+\z! or next; @@ -288,7 +288,7 @@ sub idx_init { $self->lock_acquire unless ($opt && $opt->{-skip_lock}); $over->create; - # -compact can change partition count while -watch is idle + # xcpdb can change shard count while -watch is idle my $nparts = count_partitions($self); if ($nparts && $nparts != $self->{partitions}) { $self->{partitions} = $nparts;