From 0aa49f48a52fba4c0a6d62be1f73e9ba4e31477d Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 2 Oct 2021 11:18:35 +0000 Subject: [PATCH] extsearchidx: emit diagnostics for missing blobs I'm not sure why they weren't emitted, earlier. --- lib/PublicInbox/ExtSearchIdx.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index 972049e4..eb7c3d67 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -223,13 +223,16 @@ sub _blob_missing ($$) { # called when $smsg->{blob} is bad my $xref3 = $self->{oidx}->get_xref3($smsg->{num}); my @keep = grep(!/:$smsg->{blob}\z/, @$xref3); if (@keep) { + warn "E: $smsg->{blob} gone, removing #$smsg->{num}\n"; $keep[0] =~ /:([a-f0-9]{40,}+)\z/ or die "BUG: xref $keep[0] has no OID"; my $oidhex = $1; $self->{oidx}->remove_xref3($smsg->{num}, $smsg->{blob}); - my $upd = $self->{oidx}->update_blob($smsg, $oidhex); - my $saved = $self->{oidx}->get_art($smsg->{num}); + $self->{oidx}->update_blob($smsg, $oidhex) or warn <{num} gone ($smsg->{blob} => $oidhex) +EOM } else { + warn "E: $smsg->{blob} gone, removing #$smsg->{num}\n"; $self->{oidx}->delete_by_num($smsg->{num}); } } -- 2.44.0