From 0af2aaf85fd9c556150f509e5220391240f734cc Mon Sep 17 00:00:00 2001 From: Matt Joiner Date: Tue, 13 Feb 2018 11:18:23 +1100 Subject: [PATCH] Add a bunch of TODOs --- tracker/http.go | 3 ++- tracker/tracker.go | 2 ++ tracker/udp.go | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/tracker/http.go b/tracker/http.go index 6c9dcafc..36cfa303 100644 --- a/tracker/http.go +++ b/tracker/http.go @@ -78,7 +78,8 @@ func setAnnounceParams(_url *url.URL, ar *AnnounceRequest) { } // http://stackoverflow.com/questions/17418004/why-does-tracker-server-not-understand-my-request-bittorrent-protocol q.Set("compact", "1") - // According to https://wiki.vuze.com/w/Message_Stream_Encryption. + // According to https://wiki.vuze.com/w/Message_Stream_Encryption. TODO: + // Take EncryptionPolicy or something like it as a parameter. q.Set("supportcrypto", "1") _url.RawQuery = q.Encode() diff --git a/tracker/tracker.go b/tracker/tracker.go index 9ee824c0..f2cea82e 100644 --- a/tracker/tracker.go +++ b/tracker/tracker.go @@ -47,6 +47,8 @@ var ( ErrBadScheme = errors.New("unknown scheme") ) +// TODO: Just split udp/http announcing completely, to support various different options they have. + func Announce(cl *http.Client, userAgent string, urlStr string, req *AnnounceRequest) (res AnnounceResponse, err error) { return AnnounceHost(cl, userAgent, urlStr, req, "") } diff --git a/tracker/udp.go b/tracker/udp.go index 0302a4e8..8c3b632d 100644 --- a/tracker/udp.go +++ b/tracker/udp.go @@ -257,6 +257,8 @@ func (c *udpAnnounce) connect() (err error) { return } +// TODO: Split on IPv6, as BEP 15 says response peer decoding depends on +// network in use. func announceUDP(ar *AnnounceRequest, _url *url.URL) (AnnounceResponse, error) { ua := udpAnnounce{ url: *_url, -- 2.50.0