From 0cdb33ede000457a4cf7111d2a9d2b6608d9b3e3 Mon Sep 17 00:00:00 2001
From: Shubhendra Singh Chauhan <withshubh@gmail.com>
Date: Sat, 16 Jan 2021 16:29:36 +0530
Subject: [PATCH] fixed code quality issues using DeepSource

* Added .deepsource.toml

* Removed empty default in select

* Removed unnecessary use of slice

* Fixed check for empty string
---
 .deepsource.toml             | 11 +++++++++++
 fs/torrentfs.go              |  4 ++--
 mse/mse.go                   |  2 +-
 mse/mse_test.go              |  2 +-
 webtorrent/tracker_client.go |  2 +-
 5 files changed, 16 insertions(+), 5 deletions(-)
 create mode 100644 .deepsource.toml

diff --git a/.deepsource.toml b/.deepsource.toml
new file mode 100644
index 00000000..6c68e6d8
--- /dev/null
+++ b/.deepsource.toml
@@ -0,0 +1,11 @@
+version = 1
+
+test_patterns = ["**/*_test.go"]
+
+[[analyzers]]
+name = "go"
+enabled = true
+
+  [analyzers.meta]
+  import_paths = ["github.com/anacrolix/torrent"]
+  
diff --git a/fs/torrentfs.go b/fs/torrentfs.go
index 0b3b7a91..aedab1af 100644
--- a/fs/torrentfs.go
+++ b/fs/torrentfs.go
@@ -60,14 +60,14 @@ var (
 )
 
 func isSubPath(parent, child string) bool {
-	if len(parent) == 0 {
+	if parent == "" {
 		return len(child) > 0
 	}
 	if !strings.HasPrefix(child, parent) {
 		return false
 	}
 	extra := child[len(parent):]
-	if len(extra) == 0 {
+	if extra == "" {
 		return false
 	}
 	// Not just a file with more stuff on the end.
diff --git a/mse/mse.go b/mse/mse.go
index d4a0368e..a2f2d1d9 100644
--- a/mse/mse.go
+++ b/mse/mse.go
@@ -133,7 +133,7 @@ func (cr *cipherWriter) Write(b []byte) (n int, err error) {
 			return ret
 		}
 	}()
-	cr.c.XORKeyStream(be[:], b)
+	cr.c.XORKeyStream(be, b)
 	n, err = cr.w.Write(be[:len(b)])
 	if n != len(b) {
 		// The cipher will have advanced beyond the callers stream position.
diff --git a/mse/mse_test.go b/mse/mse_test.go
index b10ca8f9..f13c259f 100644
--- a/mse/mse_test.go
+++ b/mse/mse_test.go
@@ -87,7 +87,7 @@ func handshakeTest(t testing.TB, ia []byte, aData, bData string, cryptoProvides
 		go b.Write([]byte(bData))
 		// Need to be exact here, as there are several reads, and net.Pipe is most synchronous.
 		msg := make([]byte, len(ia)+len(aData))
-		n, _ := io.ReadFull(b, msg[:])
+		n, _ := io.ReadFull(b, msg)
 		if n != len(msg) {
 			t.FailNow()
 		}
diff --git a/webtorrent/tracker_client.go b/webtorrent/tracker_client.go
index 0fe980c7..004825c8 100644
--- a/webtorrent/tracker_client.go
+++ b/webtorrent/tracker_client.go
@@ -92,7 +92,7 @@ func (tc *TrackerClient) doWebsocket() error {
 				}
 			case <-closeChan:
 				return
-			default:
+
 			}
 		}
 	}()
-- 
2.48.1