From 26b19adf05338a0842d914a10699842620ab8f90 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 17 Jul 2020 06:31:49 +0000 Subject: [PATCH] drop binmode usage We only support Unix-like platforms where binmode (":raw") is the default anyways, and v5.10 semantics means it won't do unicode_strings (unlike v5.12). So save some lines of code. --- lib/PublicInbox/Import.pm | 2 -- lib/PublicInbox/SearchIdxShard.pm | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm index fb813159..b61d4b31 100644 --- a/lib/PublicInbox/Import.pm +++ b/lib/PublicInbox/Import.pm @@ -73,8 +73,6 @@ sub gfi_start { $self->{out} = $out_w; $self->{pid} = $pid; $self->{nchg} = 0; - binmode $out_w, ':raw' or die "binmode :raw failed: $!"; - binmode $in_r, ':raw' or die "binmode :raw failed: $!"; ($in_r, $out_w); } diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm index baf7352a..b51d148b 100644 --- a/lib/PublicInbox/SearchIdxShard.pm +++ b/lib/PublicInbox/SearchIdxShard.pm @@ -26,8 +26,6 @@ sub spawn_worker { my ($self, $v2w, $shard) = @_; my ($r, $w); pipe($r, $w) or die "pipe failed: $!\n"; - binmode $r, ':raw'; - binmode $w, ':raw'; $w->autoflush(1); my $pid = fork; defined $pid or die "fork failed: $!\n"; -- 2.50.0