From 2cf7a4e1fc4fffa750462e1eb848beca0072d7b9 Mon Sep 17 00:00:00 2001 From: Matt Joiner Date: Thu, 7 Aug 2025 15:48:06 +1000 Subject: [PATCH] TODO on stat atomics being out of sync --- webseed-peer.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/webseed-peer.go b/webseed-peer.go index cf3a9e01..852716ab 100644 --- a/webseed-peer.go +++ b/webseed-peer.go @@ -302,6 +302,8 @@ func (ws *webseedPeer) readChunks(wr *webseedRequest) (err error) { err = fmt.Errorf("reading chunk: %w", err) return } + // TODO: This happens outside Client lock, and stats can be written out of sync with each + // other. Why even bother with atomics? ws.peer.doChunkReadStats(int64(n)) // TODO: Clean up the parameters for receiveChunk. msg.Piece = buf -- 2.51.0