From 38f2f94b97199f0f81fb93ab6d3c34651b661d6c Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Mon, 16 Aug 2021 23:35:20 +0000
Subject: [PATCH] view: remove mbox.gz and Atom from topic view
This declutters the topic view since these links seem rarely
used. Atom and mbox.gz links probably make most sense when
users have read the HTML and decide the topic is worth following
or downloading.
Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Link: https://public-inbox.org/meta/20210816154444.sj3ks2sikq3x2ywx@nitro.local/
---
lib/PublicInbox/View.pm | 4 +---
t/psgi_bad_mids.t | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index c80a675e..17d38302 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -1154,10 +1154,8 @@ sub dump_topics {
$anchor = '#t'; # thread skeleton
}
- my $mbox = qq(<a\nhref="$href/t.mbox.gz">mbox.gz</a>);
- my $atom = qq(<a\nhref="$href/t.atom">Atom</a>);
my $s = "<a\nhref=\"$href/T/$anchor\">$top_subj</a>\n" .
- " $ds UTC $n - $mbox / $atom\n";
+ " $ds UTC $n\n";
for (my $i = 0; $i < scalar(@extra); $i += 2) {
my $level = $extra[$i];
my $subj = $extra[$i + 1]; # already normalized
diff --git a/t/psgi_bad_mids.t b/t/psgi_bad_mids.t
index f92e4f97..8e531b54 100644
--- a/t/psgi_bad_mids.t
+++ b/t/psgi_bad_mids.t
@@ -53,7 +53,7 @@ test_psgi(sub { $www->call(@_) }, sub {
ok(index($raw, $mid) < 0, "escaped $mid");
}
- my (@xmids) = ($raw =~ m!\bhref="([^"]+)/t\.mbox\.gz"!sg);
+ my (@xmids) = ($raw =~ m!\bhref="([^"]+?)/T/#u"!sg);
is(scalar(@xmids), scalar(@mids),
'got escaped links to all messages');
--
2.51.0