From 3a40128f8418d3c3bc826a1d45ca907478339190 Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Mon, 22 Feb 2021 08:22:58 -0300
Subject: [PATCH] lei convert: inline convert_start
Since we stopped using LeiAuth as a WQ worker, keeping this
around as a single-use sub makes no sense and wastes several
KB of memory.
---
lib/PublicInbox/LeiConvert.pm | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/lib/PublicInbox/LeiConvert.pm b/lib/PublicInbox/LeiConvert.pm
index b45de4e0..4839dea4 100644
--- a/lib/PublicInbox/LeiConvert.pm
+++ b/lib/PublicInbox/LeiConvert.pm
@@ -62,17 +62,6 @@ sub do_convert { # via wq_do
delete $self->{wcb}; # commit
}
-sub convert_start {
- my ($lei) = @_;
- my $self = $lei->{cnv};
- my $op = $lei->workers_start($self, 'lei_convert', 1, {
- '' => [ $lei->can('dclose'), $lei ]
- });
- $self->wq_io_do('do_convert', []);
- $self->wq_close(1);
- while ($op && $op->{sock}) { $op->event_step }
-}
-
sub call { # the main "lei convert" method
my ($cls, $lei, @inputs) = @_;
my $opt = $lei->{opt};
@@ -131,7 +120,12 @@ sub call { # the main "lei convert" method
$nrd->{quiet} = $opt->{quiet};
$lei->{nrd} = $nrd;
}
- convert_start($lei);
+ my $op = $lei->workers_start($self, 'lei_convert', 1, {
+ '' => [ $lei->can('dclose'), $lei ]
+ });
+ $self->wq_io_do('do_convert', []);
+ $self->wq_close(1);
+ while ($op && $op->{sock}) { $op->event_step }
}
sub ipc_atfork_child {
--
2.50.0