From 48f27c6d4b3705803b192cf34a6aee0962f64b50 Mon Sep 17 00:00:00 2001 From: Matt Joiner Date: Fri, 22 Mar 2024 08:15:10 +1100 Subject: [PATCH] Update PiecePriority --- types/types.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/types/types.go b/types/types.go index 8ec7aedf..df9284a5 100644 --- a/types/types.go +++ b/types/types.go @@ -1,3 +1,5 @@ +// package types contains types that are used by the request strategy and the torrent package and +// need to be shared between them. package types import ( @@ -35,18 +37,14 @@ func (pp *PiecePriority) Raise(maybe PiecePriority) bool { return false } -// Priority for use in PriorityBitmap -func (me PiecePriority) BitmapPriority() int { - return -int(me) -} - const ( PiecePriorityNone PiecePriority = iota // Not wanted. Must be the zero value. PiecePriorityNormal // Wanted. PiecePriorityHigh // Wanted a lot. PiecePriorityReadahead // May be required soon. - // Succeeds a piece where a read occurred. Currently, the same as Now, apparently due to issues - // with caching. + // Deprecated. Succeeds a piece where a read occurred. This used to prioritize the earlier + // pieces in the readahead window. The request strategy now does this, so it's no longer needed. + // There is downstream code that still assumes it's in use. PiecePriorityNext PiecePriorityNow // A Reader is reading in this piece. Highest urgency. ) -- 2.48.1