From 55b22e6414b78336633ca243c113c712af2c3bcd Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 23 Apr 2018 04:16:54 +0000 Subject: [PATCH] view: drop redundant References: display code We no longer need to parse and dedupe References: ourselves, PublicInbox::MID::references does it for us. --- lib/PublicInbox/View.pm | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 73394671..58851edc 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -723,7 +723,8 @@ sub _parent_headers { my ($hdr, $srch) = @_; my $rv = ''; - my $irt = in_reply_to($hdr); + my $refs = references($hdr); + my $irt = pop @$refs; if (defined $irt) { my $v = PublicInbox::Hval->new_msgid($irt); my $html = $v->as_html; @@ -736,22 +737,9 @@ sub _parent_headers { # we show the thread skeleton at the bottom, instead. return $rv if $srch; - my $refs = $hdr->header_raw('References'); - if ($refs) { - # avoid redundant URLs wasting bandwidth - my %seen; - $seen{$irt} = 1 if defined $irt; - my @refs; - my @raw_refs = ($refs =~ /<([^>]+)>/g); - foreach my $ref (@raw_refs) { - next if $seen{$ref}; - $seen{$ref} = 1; - push @refs, linkify_ref_nosrch($ref); - } - - if (@refs) { - $rv .= 'References: '. join("\n\t", @refs) . "\n"; - } + if (@$refs) { + @$refs = map { linkify_ref_nosrch($_) } @$refs; + $rv .= 'References: '. join("\n\t", @$refs) . "\n"; } $rv; } -- 2.50.0