From 695aa875bb5ee37c03a4e0ff4ef7d0ec7802a933 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 10 Oct 2022 21:34:20 +0000 Subject: [PATCH] viewvcs: avoid one ascii_html call We can reuse its result for the button text. --- lib/PublicInbox/ViewVCS.pm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index 72b79ab7..86bae7d6 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -247,9 +247,14 @@ EOM my $rows = ($q =~ tr/\n/\n/) + 1; $q = ascii_html($q); my $ibx_url = ibx_url_for($ctx); - my $alt = $ibx_url ? ' '.ascii_html($ibx_url) : ''; - $ibx_url = ascii_html($ibx_url) if defined $ibx_url; - $ibx_url //= $upfx; + my $alt; + if (defined $ibx_url) { + $ibx_url = ascii_html($ibx_url); + $alt = ' '.$ibx_url; + } else { + $ibx_url = $upfx; + $alt = ''; + } print $zfh <