From 80424a6a72dbe2b1ea7ba9bfba8f273e4da385a7 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 23 Dec 2020 08:38:51 +0000 Subject: [PATCH] config: git_config_dump: pre-compile RE for split It appears the Perl split() operator is not optimized for fixed strings at all. With this change, PublicInbox::Config->new (w/o ->fill_all) time is reduced from 1.81s to 1.22s on a config file with 50K inboxes. --- lib/PublicInbox/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm index cd8957a1..4d143c6e 100644 --- a/lib/PublicInbox/Config.pm +++ b/lib/PublicInbox/Config.pm @@ -165,7 +165,7 @@ sub git_config_dump { return {} unless -e $file; my $cmd = [ qw(git config -z -l --includes), "--file=$file" ]; my $fh = popen_rd($cmd); - my $rv = config_fh_parse($fh, "\0", "\n"); + my $rv = config_fh_parse($fh, "\0", qr/\n/); close $fh or die "failed to close (@$cmd) pipe: $?"; $rv; } -- 2.44.0