From 97b286ab94b69293d8b58a280321560b79c1afeb Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 24 Jan 2021 17:18:54 -0800 Subject: [PATCH] lei q: drop "oid" output format The default deduplication command-line arguments would be non-sensical for such an option and probably confusing. It doesn't seem worth the code to support OID-only output when it's easy enough to use one of the JSON formats to extract the same info. We also don't have OIDs if using remotes, and the to-be-implemented memoization will be optional. --- lib/PublicInbox/LEI.pm | 3 ++- lib/PublicInbox/LeiOverview.pm | 4 ---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index 378113e8..09eac58c 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -200,7 +200,8 @@ my %OPTDESC = ( 'message/object output format' ], 'mark format|f=s' => $stdin_formats, 'forget format|f=s' => $stdin_formats, -'q format|f=s' => [ 'OUT|maildir|mboxrd|mboxcl2|mboxcl|html|oid|json', +'q format|f=s' => [ + 'OUT|maildir|mboxrd|mboxcl2|mboxcl|html|json|jsonl|concatjson', 'specify output format, default depends on --output'], 'ls-query format|f=s' => $ls_format, 'ls-external format|f=s' => $ls_format, diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm index 880c7acc..ea35871c 100644 --- a/lib/PublicInbox/LeiOverview.pm +++ b/lib/PublicInbox/LeiOverview.pm @@ -286,10 +286,6 @@ sub ovv_each_smsg_cb { # runs in wq worker usually $buf = ''; } } - } elsif ($self->{fmt} eq 'oid') { - sub { - my ($smsg, $mitem) = @_; - } } # else { ... } -- 2.50.0