From 99acd1de608f99d90cca15737b71a68f21108d20 Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Wed, 23 Nov 2022 04:09:57 +0000
Subject: [PATCH] config: urlmatch $? does not influence our exits
We don't want to leak $? from `git config' failures into
lei nor public-inbox-* processes.
---
lib/PublicInbox/Config.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index c27928de..6a51226e 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -544,11 +544,12 @@ sub urlmatch {
my $val = <$fh>;
if (close($fh)) {
chomp($val);
- $val;
} else {
$urlmatch_broken = 1 if (($? >> 8) != 1);
- undef;
+ undef $val;
}
+ $? = 0; # don't influence lei exit status
+ $val;
}
sub json {
--
2.50.0