From 9be6c1a5e2fc40568d5d52cecc2aad88e2f6238e Mon Sep 17 00:00:00 2001 From: NRK Date: Tue, 22 Mar 2022 17:50:54 +0600 Subject: [PATCH] avoid unnessary heap allocation the binary size shouldn't change since it'll most likely go into the bss section. --- src/nnn.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/nnn.c b/src/nnn.c index 841df294..07bb1ecf 100644 --- a/src/nnn.c +++ b/src/nnn.c @@ -456,7 +456,7 @@ static char *plgpath; static char *pnamebuf, *pselbuf, *findselpos; static char *mark; #ifndef NOX11 -static char *hostname; +static char hostname[_POSIX_HOST_NAME_MAX + 1]; #endif #ifndef NOFIFO static char *fifopath; @@ -8265,8 +8265,6 @@ static void cleanup(void) if (cfg.x11 && !g_state.picker) { printf("\033[23;0t"); /* reset terminal window title */ fflush(stdout); - - free(hostname); } #endif free(selpath); @@ -8708,14 +8706,8 @@ int main(int argc, char *argv[]) /* Save terminal window title */ printf("\033[22;0t"); fflush(stdout); - - hostname = malloc(_POSIX_HOST_NAME_MAX + 1); - if (!hostname) { - xerror(); - return EXIT_FAILURE; - } - gethostname(hostname, _POSIX_HOST_NAME_MAX); - hostname[_POSIX_HOST_NAME_MAX] = '\0'; + gethostname(hostname, sizeof(hostname)); + hostname[sizeof(hostname) - 1] = '\0'; } #endif -- 2.48.1