From a9d5304cfc5c35cd4520fc7f08a1b9d203e1f3eb Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 31 Aug 2021 11:21:17 +0000 Subject: [PATCH] lei_mail_sync: forget_folder: simplify code No need to bump refcounts of {dbh} nor declare extra variables for a rarely-called function. --- lib/PublicInbox/LeiMailSync.pm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/PublicInbox/LeiMailSync.pm b/lib/PublicInbox/LeiMailSync.pm index b63f8dea..57b56b3c 100644 --- a/lib/PublicInbox/LeiMailSync.pm +++ b/lib/PublicInbox/LeiMailSync.pm @@ -403,13 +403,11 @@ EOF sub forget_folder { my ($self, $folder) = @_; - my ($fid, $sth); - $fid = delete($self->{fmap}->{$folder}) // + my $fid = delete($self->{fmap}->{$folder}) // fid_for($self, $folder) // return; - my $dbh = $self->{dbh}; - $dbh->do('DELETE FROM blob2name WHERE fid = ?', undef, $fid); - $dbh->do('DELETE FROM blob2num WHERE fid = ?', undef, $fid); - $dbh->do('DELETE FROM folders WHERE fid = ?', undef, $fid); + for my $t (qw(blob2name blob2num folders)) { + $self->{dbh}->do("DELETE FROM $t WHERE fid = ?", undef, $fid); + } } # only used for changing canonicalization errors -- 2.48.1